ci: run on Node 24 and require Node 22+ - #72
Merged
Merged
Conversation
CI pinned node-version 20, which reached end of life in April 2026, and the root engines field still allowed it. The gap surfaced through the jsdom 30 bump (#66): jsdom now requires ^22.22.2 || ^24.15.0 || >=26, so the context-pruning suite crashed inside undici on Node 20 rather than reporting a test failure. Runs CI on Node 24, the current LTS and what the suites are developed against, and raises the engines floor to 22. Verified pnpm test:runtime still passes locally and reproduces the documented pruning numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced by the jsdom bump (#66), but a problem regardless of it.
CI pinned
node-version: 20. Node 20 reached end of life in April 2026 — four months ago — andengines.nodestill said>=20.jsdom 30 requires
^22.22.2 || ^24.15.0 || >=26.0.0, so on Node 20 the context-pruning suite did not fail a test, it crashed inside undici:Change
engines.noderaised to>=22.CONTRIBUTING.mdupdated to match.Verified
pnpm test:runtimepasses locally on Node 24 and reproduces the documented pruning numbers (48,428 → 895 bytes, 94.5 % reduction).Once this lands, #66 (jsdom 30) should be re-run and can go green.